Attention is currently required from: Ashish Kumar Mishra, Bob Moragues, Karthik Ramasubramanian, Nick Vaccaro.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80564?usp=email )
Change subject: mb/google/brox: Handle bluetooth enable on devices
......................................................................
Patch Set 2: -Code-Review
(1 comment)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80564/comment/2b79eea4_9e81b570 :
PS2, Line 24: field BT 10 10
: option BT_DISCRETE 0
: option BT_CNVI 1
: end
Why do we need this when we already have WIFI_CNVI/WIFI_PCIE? Can we not leverage that?
I also was wondering, but I came to the conclusion that having a separate FW config for bluetooth would be more flexible for us in the future in case a design doesn't use CNVi bluetooth but does use CNVi WIFI?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80564?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iba008682fcfa7ddc1ec400649c8742c721666f1d
Gerrit-Change-Number: 80564
Gerrit-PatchSet: 2
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: srinivas.kulkarni@intel.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 15 Feb 2024 16:56:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment