Attention is currently required from: Julius Werner, Yu-Ping Wu.
Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62850 )
Change subject: libpayload: Add struct name "channel" for external access
......................................................................
Patch Set 2:
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/mem_chip_info.h:
https://review.coreboot.org/c/coreboot/+/62850/comment/5b5f0655_ac783235
PS2, Line 18: channel
mem_chip_channel
Maybe the name "channel" is shorter? And the structure is in "mem_chip_info", i think we can ignore the prefix "mem_chip_"?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62850
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8dcd3b52f33f80afb7885ffdcad826d86b54b543
Gerrit-Change-Number: 62850
Gerrit-PatchSet: 2
Gerrit-Owner: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi kumar
rbokka@codeaurora.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 16 Mar 2022 08:16:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment