Change in coreboot[master]: vendorcode/amd/agesa/f15tn: Fix condition that has identical branches
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34225 )
Change subject: vendorcode/amd/agesa/f15tn: Fix condition that has identical branches ......................................................................
vendorcode/amd/agesa/f15tn: Fix condition that has identical branches
Change-Id: Ia004756a0b301278f813067ab0ea580c5ea837d3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15Utilities.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/34225/1
diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15Utilities.c b/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15Utilities.c index b1aa92b..b60eb51 100644 --- a/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15Utilities.c +++ b/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15Utilities.c @@ -1035,7 +1035,7 @@ for (Sublink = 0; Sublink < 2; Sublink++) { CapabilitySet = StartingCapabilitySet; Link = 0; - DesiredLinkFeats.HtPhyLinkValue = ((Sublink == 0) ? HTPHY_LINKTYPE_SL0_HT3 : HTPHY_LINKTYPE_SL0_HT3); + DesiredLinkFeats.HtPhyLinkValue = ((Sublink == 0) ? HTPHY_LINKTYPE_SL0_HT3 : HTPHY_LINKTYPE_SL1_HT3); while (FamilySpecificServices->NextLinkHasHtPhyFeats ( FamilySpecificServices, &CapabilitySet,
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34225 )
Change subject: vendorcode/amd/agesa/f15tn: Fix condition that has identical branches ......................................................................
Patch Set 1: Code-Review+2
Please check and add in the commit message we never call the function you fix here.
Hello Kyösti Mälkki, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34225
to look at the new patch set (#2).
Change subject: vendorcode/amd/agesa/f15tn: Fix condition that has identical branches ......................................................................
vendorcode/amd/agesa/f15tn: Fix condition that has identical branches
This fixed function is never used.
Change-Id: Ia004756a0b301278f813067ab0ea580c5ea837d3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15Utilities.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/34225/2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34225 )
Change subject: vendorcode/amd/agesa/f15tn: Fix condition that has identical branches ......................................................................
Patch Set 2: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34225 )
Change subject: vendorcode/amd/agesa/f15tn: Fix condition that has identical branches ......................................................................
vendorcode/amd/agesa/f15tn: Fix condition that has identical branches
This fixed function is never used.
Change-Id: Ia004756a0b301278f813067ab0ea580c5ea837d3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/34225 Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15Utilities.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Martin Roth: Looks good to me, approved
diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15Utilities.c b/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15Utilities.c index b1aa92b..b60eb51 100644 --- a/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15Utilities.c +++ b/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15Utilities.c @@ -1035,7 +1035,7 @@ for (Sublink = 0; Sublink < 2; Sublink++) { CapabilitySet = StartingCapabilitySet; Link = 0; - DesiredLinkFeats.HtPhyLinkValue = ((Sublink == 0) ? HTPHY_LINKTYPE_SL0_HT3 : HTPHY_LINKTYPE_SL0_HT3); + DesiredLinkFeats.HtPhyLinkValue = ((Sublink == 0) ? HTPHY_LINKTYPE_SL0_HT3 : HTPHY_LINKTYPE_SL1_HT3); while (FamilySpecificServices->NextLinkHasHtPhyFeats ( FamilySpecificServices, &CapabilitySet,
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)
-
Martin Roth (Code Review)