Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39104 )
Change subject: mb/asrock/h110m: add libgfxinit support
......................................................................
Patch Set 11:
(1 comment)
Thanks for the review
https://review.coreboot.org/c/coreboot/+/39104/10//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39104/10//COMMIT_MSG@7
PS10, Line 7: mb/asrock/h110m: add libgfxinit support
You should remove the "Analog" port in gma-mainboard.ads, as it does not exist.
The board contains a VGA connector, but it doesn't work with libgfx.
Should I remove this anyway?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39104
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d87413f87d00986111ecb7b046423ff5eac1bf1
Gerrit-Change-Number: 39104
Gerrit-PatchSet: 11
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Mar 2020 17:39:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment