Change in coreboot[master]: soc/intel/skylake: vr_config: enable PSI3 and PSI4 by default

[Benjamin Doron (Code Review)]

Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39980 )

Change subject: soc/intel/skylake: vr_config: enable PSI3 and PSI4 by default
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39980/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39980/3//COMMIT_MSG@18 
PS3, Line 18: Boards that have a domain_vr_config and set their specific settings are
> I'd like to have a way to dump the vendor information from the vendor image and/or read it by intelt […]
> I've found that a lot of information is available in the vendor's advanced settings.

For me, they were not visible by default (laptops seem to be particularly guilty in this regard) and I de-suppressed and enabled an option named "i-Page" (Intel page, perhaps) in the IFR (by hex) of the vendor's Setup utility UEFI module.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/39980
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b5fd9fb3b9b89e80c47f15d706e2dd62dcc0748
Gerrit-Change-Number: 39980
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin <[e-mail]>
Gerrit-Reviewer: Benjamin Doron <[e-mail]>
Gerrit-Reviewer: Christian Walter <[e-mail]>
Gerrit-Reviewer: Matt DeVillier <[e-mail]>
Gerrit-Reviewer: Matthew Garrett <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Wed, 01 Apr 2020 20:34:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment