Change in coreboot[master]: mb/google/zork: add MST details to trembyle devicetree

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Shiyu Sun (Code Review)

1 Dec 2020 1 Dec '20

9:35 p.m.

Shiyu Sun has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48229 )

Change subject: mb/google/zork: add MST details to trembyle devicetree ......................................................................

mb/google/zork: add MST details to trembyle devicetree

Added device hid info to the MST RTD2141b device on trembyle.

BRANCH=None BUG=b:147402710 TEST=Build and flash BIOS image, see 10EC2141 appears under /sys/bus/i2c/devices

Signed-off-by: Shiyu Sun sshiyu@chromium.org Change-Id: I97a67f9dbc31cd788d579252d7d355b24d97ca30 --- M src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb 1 file changed, 9 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/48229/1

diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb index 4181b4a..5e10696 100644 --- a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb +++ b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb @@ -371,7 +371,15 @@ register "name" = ""MSTH"" register "uid" = "1" register "remote_bus" = "9" - device generic 1.0 on end + device generic 1.0 on + chip drivers/i2c/generic + register "hid" = ""10EC2141"" + register "name" = ""MSTH"" + register "uid" = "1" + register "desc" = ""Realtek RTD2141B"" + device i2c 1b on end + end + end end chip ec/google/chromeec/audio_codec register "uid" = "1"

Attachments:

attachment.htm (text/html — 3.6 KB)

Show replies by date

Sam McNally (Code Review)

21 Jan 21 Jan

12:02 a.m.

Attention is currently required from: Shiyu Sun, Edward Hill. Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48229 )

Change subject: mb/google/zork: add MST details to trembyle devicetree ......................................................................

Patch Set 1:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/48229/comment/e7a92ec9_ca6e5cbd PS1, Line 12: BRANCH=None BRANCH=zork

-- To view, visit https://review.coreboot.org/c/coreboot/+/48229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97a67f9dbc31cd788d579252d7d355b24d97ca30 Gerrit-Change-Number: 48229 Gerrit-PatchSet: 1 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Matthew Blecker matthewb@chromium.org Gerrit-Attention: Shiyu Sun sshiyu@google.com Gerrit-Attention: Edward Hill ecgh@chromium.org Gerrit-Comment-Date: Thu, 21 Jan 2021 08:02:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shiyu Sun (Code Review)

6:42 a.m.

Attention is currently required from: Shiyu Sun, Edward Hill. Hello Sam McNally, build bot (Jenkins), Edward Hill,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48229

to look at the new patch set (#2).

Change subject: mb/google/zork: add MST details to trembyle devicetree ......................................................................

mb/google/zork: add MST details to trembyle devicetree

Added device hid info to the MST RTD2141b device on trembyle.

BRANCH=zork BUG=b:147402710 TEST=Build and flash BIOS image, see 10EC2141 appears under /sys/bus/i2c/devices

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/48229/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97a67f9dbc31cd788d579252d7d355b24d97ca30 Gerrit-Change-Number: 48229 Gerrit-PatchSet: 2 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Matthew Blecker matthewb@chromium.org Gerrit-Attention: Shiyu Sun sshiyu@google.com Gerrit-Attention: Edward Hill ecgh@chromium.org Gerrit-MessageType: newpatchset

Shiyu Sun (Code Review)

6:42 a.m.

Attention is currently required from: Sam McNally, Edward Hill. Shiyu Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48229 )

Change subject: mb/google/zork: add MST details to trembyle devicetree ......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/48229/comment/2cbbb45a_22317b4b PS1, Line 12: BRANCH=None

...

BRANCH=zork

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97a67f9dbc31cd788d579252d7d355b24d97ca30 Gerrit-Change-Number: 48229 Gerrit-PatchSet: 2 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Matthew Blecker matthewb@chromium.org Gerrit-Attention: Sam McNally sammc@google.com Gerrit-Attention: Edward Hill ecgh@chromium.org Gerrit-Comment-Date: Thu, 21 Jan 2021 14:42:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sam McNally sammc@google.com Gerrit-MessageType: comment

Sam McNally (Code Review)

5:29 p.m.

Attention is currently required from: Shiyu Sun, Edward Hill. Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48229 )

Change subject: mb/google/zork: add MST details to trembyle devicetree ......................................................................

Patch Set 2:

(1 comment)

File src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb:

https://review.coreboot.org/c/coreboot/+/48229/comment/bd76a5d2_a43c9b86 PS2, Line 380: 1b 35

-- To view, visit https://review.coreboot.org/c/coreboot/+/48229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97a67f9dbc31cd788d579252d7d355b24d97ca30 Gerrit-Change-Number: 48229 Gerrit-PatchSet: 2 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Matthew Blecker matthewb@chromium.org Gerrit-Attention: Shiyu Sun sshiyu@google.com Gerrit-Attention: Edward Hill ecgh@chromium.org Gerrit-Comment-Date: Fri, 22 Jan 2021 01:29:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shiyu Sun (Code Review)

22 Jan 22 Jan

6:50 p.m.

Attention is currently required from: Sam McNally, Edward Hill. Shiyu Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48229 )

Change subject: mb/google/zork: add MST details to trembyle devicetree ......................................................................

Patch Set 2:

(1 comment)

File src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb:

https://review.coreboot.org/c/coreboot/+/48229/comment/d3ea3830_b45f37ac PS2, Line 380: 1b

...

35

Sorry may I know where this number come from?

-- To view, visit https://review.coreboot.org/c/coreboot/+/48229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97a67f9dbc31cd788d579252d7d355b24d97ca30 Gerrit-Change-Number: 48229 Gerrit-PatchSet: 2 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Matthew Blecker matthewb@chromium.org Gerrit-Attention: Sam McNally sammc@google.com Gerrit-Attention: Edward Hill ecgh@chromium.org Gerrit-Comment-Date: Sat, 23 Jan 2021 02:50:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sam McNally sammc@google.com Gerrit-MessageType: comment

Sam McNally (Code Review)

24 Jan 24 Jan

7:43 p.m.

Attention is currently required from: Shiyu Sun, Edward Hill. Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48229 )

Change subject: mb/google/zork: add MST details to trembyle devicetree ......................................................................

Patch Set 2:

(1 comment)

File src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb:

https://review.coreboot.org/c/coreboot/+/48229/comment/62013126_7416b58a PS2, Line 380: 1b

...

Sorry may I know where this number come from?

It's the 7-bit i2c address.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97a67f9dbc31cd788d579252d7d355b24d97ca30 Gerrit-Change-Number: 48229 Gerrit-PatchSet: 2 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Matthew Blecker matthewb@chromium.org Gerrit-Attention: Shiyu Sun sshiyu@google.com Gerrit-Attention: Edward Hill ecgh@chromium.org Gerrit-Comment-Date: Mon, 25 Jan 2021 03:43:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sam McNally sammc@google.com Comment-In-Reply-To: Shiyu Sun sshiyu@google.com Gerrit-MessageType: comment

Edward Hill (Code Review)

9:52 p.m.

Attention is currently required from: Sam McNally, Shiyu Sun. Edward Hill has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48229 )

Change subject: mb/google/zork: add MST details to trembyle devicetree ......................................................................

Patch Set 2:

(1 comment)

File src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb:

https://review.coreboot.org/c/coreboot/+/48229/comment/f162a3a8_570683ac PS2, Line 380: 1b

...

It's the 7-bit i2c address.

RTD2141B 7-bit i2c address is 0x4a.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97a67f9dbc31cd788d579252d7d355b24d97ca30 Gerrit-Change-Number: 48229 Gerrit-PatchSet: 2 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Matthew Blecker matthewb@chromium.org Gerrit-Attention: Sam McNally sammc@google.com Gerrit-Attention: Shiyu Sun sshiyu@google.com Gerrit-Comment-Date: Mon, 25 Jan 2021 05:52:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sam McNally sammc@google.com Comment-In-Reply-To: Shiyu Sun sshiyu@google.com Gerrit-MessageType: comment

Shiyu Sun (Code Review)

25 Jan 25 Jan

6:33 a.m.

Attention is currently required from: Sam McNally, Shiyu Sun. Hello Sam McNally, build bot (Jenkins), Edward Hill,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48229

to look at the new patch set (#3).

Change subject: mb/google/zork: add MST details to trembyle devicetree ......................................................................

mb/google/zork: add MST details to trembyle devicetree

Added device hid info to the MST RTD2141b device on trembyle.

BRANCH=zork BUG=b:147402710 TEST=Build and flash BIOS image, see 10EC2141 appears under /sys/bus/i2c/devices

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/48229/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/48229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97a67f9dbc31cd788d579252d7d355b24d97ca30 Gerrit-Change-Number: 48229 Gerrit-PatchSet: 3 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Matthew Blecker matthewb@chromium.org Gerrit-Attention: Sam McNally sammc@google.com Gerrit-Attention: Shiyu Sun sshiyu@google.com Gerrit-MessageType: newpatchset

Shiyu Sun (Code Review)

6:38 a.m.

Attention is currently required from: Sam McNally, Edward Hill. Shiyu Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48229 )

Change subject: mb/google/zork: add MST details to trembyle devicetree ......................................................................

Patch Set 3:

(1 comment)

File src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb:

https://review.coreboot.org/c/coreboot/+/48229/comment/a82697ad_263c8aea PS2, Line 380: 1b

...

RTD2141B 7-bit i2c address is 0x4a.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97a67f9dbc31cd788d579252d7d355b24d97ca30 Gerrit-Change-Number: 48229 Gerrit-PatchSet: 3 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Matthew Blecker matthewb@chromium.org Gerrit-Attention: Sam McNally sammc@google.com Gerrit-Attention: Edward Hill ecgh@chromium.org Gerrit-Comment-Date: Mon, 25 Jan 2021 14:38:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sam McNally sammc@google.com Comment-In-Reply-To: Shiyu Sun sshiyu@google.com Comment-In-Reply-To: Edward Hill ecgh@chromium.org Gerrit-MessageType: comment

Sam McNally (Code Review)

26 Jan 26 Jan

3:44 p.m.

Attention is currently required from: Shiyu Sun, Edward Hill. Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48229 )

Change subject: mb/google/zork: add MST details to trembyle devicetree ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97a67f9dbc31cd788d579252d7d355b24d97ca30 Gerrit-Change-Number: 48229 Gerrit-PatchSet: 3 Gerrit-Owner: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Matthew Blecker matthewb@chromium.org Gerrit-Attention: Shiyu Sun sshiyu@google.com Gerrit-Attention: Edward Hill ecgh@chromium.org Gerrit-Comment-Date: Tue, 26 Jan 2021 23:44:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

28 Jan 28 Jan

1:15 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48229 )

Change subject: mb/google/zork: add MST details to trembyle devicetree ......................................................................

mb/google/zork: add MST details to trembyle devicetree

Added device hid info to the MST RTD2141b device on trembyle.

BRANCH=zork BUG=b:147402710 TEST=Build and flash BIOS image, see 10EC2141 appears under /sys/bus/i2c/devices

Signed-off-by: Shiyu Sun sshiyu@chromium.org Change-Id: I97a67f9dbc31cd788d579252d7d355b24d97ca30 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48229 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Sam McNally sammc@google.com --- M src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb 1 file changed, 9 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, approved

diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb index 40e2ed5..5ec9010 100644 --- a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb +++ b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb @@ -371,7 +371,15 @@ register "name" = ""MSTH"" register "uid" = "1" register "remote_bus" = "9" - device generic 1.0 on end + device generic 1.0 on + chip drivers/i2c/generic + register "hid" = ""10EC2141"" + register "name" = ""MSTH"" + register "uid" = "1" + register "desc" = ""Realtek RTD2141B"" + device i2c 4a on end + end + end end chip ec/google/chromeec/audio_codec register "uid" = "1"

1464

days inactive

1521

days old

coreboot-gerrit@coreboot.org

11 comments

4 participants

tags (0)

participants (4)

Edward Hill (Code Review)
Patrick Georgi (Code Review)
Sam McNally (Code Review)
Shiyu Sun (Code Review)