Change in coreboot[master]: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support - coreboot-gerrit

28 Jan 2022


      Attention is currently required from: Bora Guvendik, Anil Kumar K, Selma Bensaid, Tim Wawrzynczak, Paul Menzel, Thejaswani Putta.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61354 )
Change subject: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/wwan/fm/acpi_fm350gl.c:
https://review.coreboot.org/c/coreboot/+/61354/comment/ab23aafe_bc17f162 
PS2, Line 38: assert
...
Oops, no you're right, I was misremembering !
not a problem at all. I will make changes for this and the other three related code review based on current accumulated feedback shortly. Thanks a lot.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/61354
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e0b9fd405f6cfb1e216ea27558bb9299a09e566
Gerrit-Change-Number: 61354
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Attention: Selma Bensaid selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Thejaswani Putta thejaswani.putta@intel.com
Gerrit-Comment-Date: Fri, 28 Jan 2022 21:31:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang cliff.huang@intel.com
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment