[M] Change in coreboot[main]: mb/google/rauru: Add 2nd source TAS2563 amps to support beep - coreboot-gerrit

2 Dec 2024


      Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85360?usp=email )
Change subject: mb/google/rauru: Add 2nd source TAS2563 amps to support beep
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5: 
Have you compiled the patch before submission ?
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85360/comment/686dbc58_fac1ad46?usp... :
PS5, Line 6: #include <gpio.h>
`soc/addressmap.h` is missing.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85360?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I10cba7964d3847f2a74341b3130ff1e7bfd8d37a
Gerrit-Change-Number: 85360
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin jarried.lin@mediatek.com
Gerrit-Reviewer: Darren Ye darren.ye@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Attention: Jarried Lin jarried.lin@mediatek.com
Gerrit-Comment-Date: Mon, 02 Dec 2024 08:00:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No