Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Karthikeyan Ramasubramanian, Felix Held.
Jan Dabros has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61863 )
Change subject: soc/amd/cezanne/acpi/mmio: Add support for shared I2C3 controller
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61863/comment/6ab6aa90_f4ca2628
PS2, Line 10: In order to handle this, PSP acts as an
: I2C-arbitrator, where x86(kernel) sends acquire and release requests to
: be accepted by PSP.
Is that documented in some datasheet? Please document the name and revision.
Actually it is not documented in any datasheet. Does this makes sense to put a link to commit (linux-next repo) with this functionality implemented?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61863
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccfc09d8c580d7ab2acb69d26b9c293cf625fb34
Gerrit-Change-Number: 61863
Gerrit-PatchSet: 2
Gerrit-Owner: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Avinash Alevoor
Gerrit-CC: Mohan Viswanathan
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 15 Feb 2022 12:40:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment