Attention is currently required from: Alexander Couzens.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950?usp=email )
Change subject: mb/lenovo/x230: introduce EDP variant
......................................................................
Patch Set 27:
(2 comments)
File src/mainboard/lenovo/x230/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/28950/comment/7dc58d67_25b3aca2 :
PS22, Line 11: bool "ThinkPad X230 eDP Mod (2K/FHD)"
With all the different mods out there, maybe it's even worth a documentation page.
Regarding brightness control, either they use LVDS
There is no such thing. LVDS doesn't do brightness control. I assume you mean
the PWM signal from the Intel chip (but that would also be used if the board
was doing eDP natively). It's not that simple though, because there are mods
that alter this signal (e.g. Nitrocaster, AFAIR) and probably others that
don't. That's why I asked to be more specific about the working setups.
If we don't know whether a particular mod should be working, that'll make
it hard to help people with this, when they show up with problems on IRC
for instance.
File src/mainboard/lenovo/x230/variants/x230_edp/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/28950/comment/8be15680_99b8272c :
PS27, Line 17: HDMI3,
The one with the panel connected won't be able to do HDMI anymore.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28950?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 27
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Alexei Sorokin
sor.alexei@meowr.ru
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Kilian Neuner
cb@9-r.net
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
rudolphpatrick05@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aleksei Kharlamov
dh@devass.club
Gerrit-CC: Charles Moyes
thechuckster@gmail.com
Gerrit-CC: Christian Herzog
Gerrit-CC: Heiki Lõhmus
h@lohmus.me
Gerrit-CC: Holger Levsen
holger@layer-acht.org
Gerrit-CC: Ivan V
ivv@i1v.org
Gerrit-CC: MartiniMoe
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Pavel Kovalenko
su@nitrocaster.me
Gerrit-CC: Sergey Alirzaev
zl29ah@gmail.com
Gerrit-CC: Stanislaw Kaminski
stanislaw.kaminski@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Tom Hiller
thrilleratplay@gmail.com
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: Xue Yao
xueyao@xyte.ch
Gerrit-CC: clayton craft
Gerrit-CC: insurgo@riseup.net
Gerrit-CC: nullmark
nullmark@googlemail.com
Gerrit-CC: slact
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 14 Feb 2024 21:42:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Ivan V
ivv@i1v.org
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Alexei Sorokin
sor.alexei@meowr.ru
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment