Attention is currently required from: Arthur Heymans, Elyes Haouas, Michał Żygowski, Sergii Dmytruk.
Krystian Hebel has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/67065?usp=email )
Change subject: 3rdparty/open-power-signing-utils: add SecureBoot utility for OpenPOWER
......................................................................
Patch Set 39:
(1 comment)
File src/soc/ibm/power9/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/67065/comment/31daeae8_69b2bc4e?usp... :
PS39, Line 17: ifneq ($(CONFIG_SIGNING_KEYS_DIR),"")
Isn't it reversed now?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67065?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id88baef5ecb1f8ffd74a7f464bbbaaaea0ca643d
Gerrit-Change-Number: 67065
Gerrit-PatchSet: 39
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Patrick Georgi
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 22 Jul 2024 13:21:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No