Change in ...coreboot[master]: vendorcode/intel/fsp/fsp2_0/cml: Add FSP header files for Cometlake

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31529 )

Change subject: vendorcode/intel/fsp/fsp2_0/cml: Add FSP header files for Cometlake
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31529/3/src/vendorcode/intel/fsp/fsp2_0/come... 
File src/vendorcode/intel/fsp/fsp2_0/cometlake/FspUpd.h:

https://review.coreboot.org/#/c/31529/3/src/vendorcode/intel/fsp/fsp2_0/come... 
PS3, Line 3: Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> Ok, but this file proves that part of the CMT FSP release were
> already
> published earlier. Then the copyright notice should state each year
> when parts of it were originally published, IMO.
>
> Also, I thought quite the opposite is common practice: that for
> each
> file, we track individually when parts of it were published.
>
> To make the scope of Intel's copyright notice clear, it would be
> nice
> if you could put a line about that above the notice in every file,
> e.g.:
>
> This file is part of the Comet Lake FSP release.
>
> Copyright (c) ...

i will feed this input and hopefully help to address ur concern
> Subrata, I hope you don't mind this discussion.

Yes, its absolutely okay to have such discussion. but sometime we have project milestone hence little hurry to make some CL merged ASAP. :)
> I already learned
> a lot, so I actually appreciate it :)