Attention is currently required from: Jason Nien, Matt DeVillier.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69453 )
Change subject: mb/google/zork: rename baseboard GPIO table getter for clarity
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
I love it, but google might be unhappy because it doesn't match the standard way that other chromeos boards work. "Uniformity is more important than clarity."
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69453
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd8ea3446ab7940b21265a3ed8080ba4029c4ff7
Gerrit-Change-Number: 69453
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 11 Nov 2022 21:35:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment