Attention is currently required from: Felix Singer, Michał Żygowski, Michał Kopeć, Stefan Reinauer, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63374 )
Change subject: util/inteltool: Add support for Alder Lake chips detection and GPIOs
......................................................................
Patch Set 7:
(1 comment)
File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/63374/comment/dd6d7b6f_fcd16e9b
PS7, Line 232: #define PCI_DEVICE_ID_INTEL_W685 0x7a8a
: #define PCI_DEVICE_ID_INTEL_WM690 0x7a8d
: #define PCI_DEVICE_ID_INTEL_HM670 0x7a8c
: #define PCI_DEVICE_ID_INTEL_WM790 0x7a0d
: #define PCI_DEVICE_ID_INTEL_HM770 0x7a0c
Where do these IDs come from?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63374
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0001395517e1e7977b0f808d5d74cf85c52298d6
Gerrit-Change-Number: 63374
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Thu, 07 Apr 2022 08:51:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Angel Pons (Code Review)