Attention is currently required from: Eric Lai, Jakub Czapiga, Kapil Porwal, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75578?usp=email )
Change subject: mb/google/rex/variants/ovis: Add USB and TCSS configuration
......................................................................
Patch Set 10:
(2 comments)
File src/mainboard/google/rex/variants/ovis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75578/comment/6ecf1b7e_00cdb9d4 :
PS10, Line 137: BOTTOM, CENTER,
IMO, the horizontal alignment could be `front/back` or 'left/center/right` and vertical alignment would be `top/center/bottom`.
I thought that u are using `horizontal, vertical, group`
https://review.coreboot.org/c/coreboot/+/75578/comment/d21aa237_8febd620 :
PS10, Line 165: ACPI_PLD_TYPE_A(FRONT, BOTTOM, ACPI_PLD_GROUP(3, 2))
need to align with patchset 10?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75578?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc81f12ec6cc4af37bcc1fcf3164cbfa5612a443
Gerrit-Change-Number: 75578
Gerrit-PatchSet: 10
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 13:41:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment