Attention is currently required from: Kane Chen, Kapil Porwal, Sridhar Siricilla, Tarun Tuli.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76880?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/mtl: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76880/comment/ff0dafa5_f2a6430a :
PS2, Line 7: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6
Maybe:
Change default for debug consent from 3 to 6
https://review.coreboot.org/c/coreboot/+/76880/comment/3b47d743_2d566f57 :
PS2, Line 9: SOC_INTEL_METEORLAKE_DEBUG_CONSENT=6 is more common use case
: for soc debug with usb dbc.
Please extend, and so why it is more common.
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/76880/comment/05b7c43e_d062f044 :
PS2, Line 357: 0:Disabled, 2:Enabled Trace Active, 4:Enabled Trace Ready,
: 6:Enable Trace Power-Off, 7:Manual
So 3, used before wasn’t even a valid value?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76880?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic12528bdd8b1feda7f1b65045c863341f932d3a2
Gerrit-Change-Number: 76880
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 02 Aug 2023 11:48:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment