Attention is currently required from: Paul Menzel, Rob Barnes. Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59839 )
Change subject: mb/google/guybrush/var/dewatt: Add dewatt device config ......................................................................
Patch Set 3: Code-Review+1
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59839/comment/7c20b666_cff5814e PS2, Line 7: initial dewatt device config
Please make it a statement by adding a verb (in imperative mood): […]
Done
https://review.coreboot.org/c/coreboot/+/59839/comment/a1d6a923_659d078f PS2, Line 7: initial
There is already some device configuration? Why “initial”?
Done
https://review.coreboot.org/c/coreboot/+/59839/comment/b23d8fd8_cc026c40 PS2, Line 7: dewatt
var/dewatt
Done
https://review.coreboot.org/c/coreboot/+/59839/comment/777daebe_86016370 PS2, Line 9: add Synaptics S9831 touch pad for dewatt : add Elan 6918 touch screen for dewatt : add Realtek 5682 , ALC1019 for dewatt
Please format it as a list.
Done
https://review.coreboot.org/c/coreboot/+/59839/comment/ba30ec1c_cdc57d80 PS2, Line 11: 5682 ,
Please remove the space.
Done
https://review.coreboot.org/c/coreboot/+/59839/comment/28879b54_070a3052 PS2, Line 12:
Where did you get the “data” from. […]
1.Synaptics S9831 product spec located in https://partnerissuetracker.corp.google.com/issues/208182457 commit#4. 2.Elan 6918 referred to other project's setting : https://review.coreboot.org/c/coreboot/+/58967/3/src/mainboard/google/dedede... 3.Realtek 5682 and ALC1019 referred to guybrush reference board setting.
-
Kenneth Chan (Code Review)