awokd@danwin1210.me has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38048 )
Change subject: vc/amd/agesa/f14/Proc/Mem: Fix uninitialized variable ......................................................................
vc/amd/agesa/f14/Proc/Mem: Fix uninitialized variable
Unitialized variable will contain an arbitrary value left from earlier computations. This issue has already been addressed in the f15tn and f16kb versions of this same file, so am backporting the fix.
Change-Id: Id876107265689e08ad6760e514a4911f32b53da7 Signed-off-by: Joe Moore awokd@danwin1210.me Found-by: Coverity CID 1241856 --- M src/vendorcode/amd/agesa/f14/Proc/Mem/Feat/S3/mfs3.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/38048/1
diff --git a/src/vendorcode/amd/agesa/f14/Proc/Mem/Feat/S3/mfs3.c b/src/vendorcode/amd/agesa/f14/Proc/Mem/Feat/S3/mfs3.c index 4963b4b..a19b8bd 100644 --- a/src/vendorcode/amd/agesa/f14/Proc/Mem/Feat/S3/mfs3.c +++ b/src/vendorcode/amd/agesa/f14/Proc/Mem/Feat/S3/mfs3.c @@ -249,6 +249,7 @@ // Base on the size of the device list, apply for a buffer for it. AllocHeapParams.RequestedBufferSize = BufferSize + sizeof (DEVICE_BLOCK_HEADER); AllocHeapParams.BufferHandle = AMD_S3_NB_INFO_BUFFER_HANDLE; + AllocHeapParams.Persist = HEAP_S3_RESUME; AGESA_TESTPOINT (TpIfBeforeAllocateMemoryS3SaveBuffer, StdHeader); if (HeapAllocateBuffer (&AllocHeapParams, StdHeader) != AGESA_SUCCESS) { return AGESA_FATAL;
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38048 )
Change subject: vc/amd/agesa/f14/Proc/Mem: Fix uninitialized variable ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38048/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38048/1//COMMIT_MSG@9 PS1, Line 9: Unitialized variable will contain an arbitrary value left from 'Uninitialized'
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38048
to look at the new patch set (#2).
Change subject: vc/amd/agesa/f14/Proc/Mem: Fix uninitialized variable ......................................................................
vc/amd/agesa/f14/Proc/Mem: Fix uninitialized variable
Uninitialized variable will contain an arbitrary value left from earlier computations. This issue has already been addressed in the f15tn and f16kb versions of this same file, so am backporting the fix.
Change-Id: Id876107265689e08ad6760e514a4911f32b53da7 Signed-off-by: Joe Moore awokd@danwin1210.me Found-by: Coverity CID 1241856 --- M src/vendorcode/amd/agesa/f14/Proc/Mem/Feat/S3/mfs3.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/38048/2
awokd@danwin1210.me has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38048 )
Change subject: vc/amd/agesa/f14/Proc/Mem: Fix uninitialized variable ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38048/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38048/1//COMMIT_MSG@9 PS1, Line 9: Unitialized variable will contain an arbitrary value left from
'Uninitialized'
Done
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38048 )
Change subject: vc/amd/agesa/f14/Proc/Mem: Fix uninitialized variable ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38048 )
Change subject: vc/amd/agesa/f14/Proc/Mem: Fix uninitialized variable ......................................................................
vc/amd/agesa/f14/Proc/Mem: Fix uninitialized variable
Uninitialized variable will contain an arbitrary value left from earlier computations. This issue has already been addressed in the f15tn and f16kb versions of this same file, so am backporting the fix.
Change-Id: Id876107265689e08ad6760e514a4911f32b53da7 Signed-off-by: Joe Moore awokd@danwin1210.me Found-by: Coverity CID 1241856 Reviewed-on: https://review.coreboot.org/c/coreboot/+/38048 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Frans Hendriks fhendriks@eltan.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/amd/agesa/f14/Proc/Mem/Feat/S3/mfs3.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Frans Hendriks: Looks good to me, but someone else must approve
diff --git a/src/vendorcode/amd/agesa/f14/Proc/Mem/Feat/S3/mfs3.c b/src/vendorcode/amd/agesa/f14/Proc/Mem/Feat/S3/mfs3.c index 4963b4b..a19b8bd 100644 --- a/src/vendorcode/amd/agesa/f14/Proc/Mem/Feat/S3/mfs3.c +++ b/src/vendorcode/amd/agesa/f14/Proc/Mem/Feat/S3/mfs3.c @@ -249,6 +249,7 @@ // Base on the size of the device list, apply for a buffer for it. AllocHeapParams.RequestedBufferSize = BufferSize + sizeof (DEVICE_BLOCK_HEADER); AllocHeapParams.BufferHandle = AMD_S3_NB_INFO_BUFFER_HANDLE; + AllocHeapParams.Persist = HEAP_S3_RESUME; AGESA_TESTPOINT (TpIfBeforeAllocateMemoryS3SaveBuffer, StdHeader); if (HeapAllocateBuffer (&AllocHeapParams, StdHeader) != AGESA_SUCCESS) { return AGESA_FATAL;
-
Frans Hendriks (Code Review) -
Name of user not set (Code Review)
-
Patrick Georgi (Code Review)