Attention is currently required from: Wonkyu Kim, Ethan Tsao, Ravishankar Sarawadi, Stefan Reinauer, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61576 )
Change subject: util/ifdtool: add PLATFORM_IFD2 to reduce common ifd tool change
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/61576/comment/d1c626af_9473f08c
PS1, Line 227: PLATFORM_V1
Got it. If we can differentiate IFDv2 and IFDv3 for later, I also think PLATFORM_IFD should be ok.
Yup, thats the point. Thanks Will.
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/61576/comment/f1f5ed84_c556c3ae
PS2, Line 1641: pv1
ifd2 ?
You can say, *platform since Skylake are belong to IFDv2*
A follow up patch can remove the for PLATFORM_SKLBKL till PLATFORM_ADL macros later.
Will you be able to pick that clean up as well and make sure we have clean design between chipset prior to IFDv2 and onwards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61576
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14a71a58c7d51b9c8b92e013b5637c6b35005f22
Gerrit-Change-Number: 61576
Gerrit-PatchSet: 2
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Sat, 05 Feb 2022 08:15:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment