Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68757 )
(
2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: drivers/ipmi/ipmi_ops.h: add __packed to sel_rec structs ......................................................................
drivers/ipmi/ipmi_ops.h: add __packed to sel_rec structs
Align with BMC on the SEL record format.
Change-Id: Icfcef684caa253663503eadffc819ad2ab65550f Signed-off-by: Yiwei Tang tangyiwei.2022@bytedance.com Signed-off-by: Jonathan Zhang jonzhang@meta.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/68757 Reviewed-by: Shuming Chu (Shuming) s1218944@gmail.com Reviewed-by: TangYiwei Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/ipmi/ipmi_ops.h 1 file changed, 21 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved TangYiwei: Looks good to me, but someone else must approve Shuming Chu (Shuming): Looks good to me, but someone else must approve
diff --git a/src/drivers/ipmi/ipmi_ops.h b/src/drivers/ipmi/ipmi_ops.h index 7a92a28..788ae85 100644 --- a/src/drivers/ipmi/ipmi_ops.h +++ b/src/drivers/ipmi/ipmi_ops.h @@ -57,17 +57,17 @@ uint8_t sensor_num; uint8_t event_dir_type; uint8_t event_data[3]; -}; +} __packed;
struct oem_ts_spec_sel_rec { uint32_t timestamp; uint8_t manf_id[3]; uint8_t oem_defined[6]; -}; +} __packed;
struct oem_nots_spec_sel_rec { uint8_t oem_defined[13]; -}; +} __packed;
/* SEL Event Record */ struct sel_event_record {