Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Simon Yang, Subrata Banik.
David Wu has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/83986?usp=email )
Change subject: mb/google/nissa/var/riven: Set VccIn Aux Imon IccMax to 25A
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/brya/variants/riven/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83986/comment/de183f64_8b654716?usp... :
PS1, Line 4:
u need to include console. […]
Done
https://review.coreboot.org/c/coreboot/+/83986/comment/77948bcb_d739877c?usp... :
PS1, Line 7: // 25 * 4
nit […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83986?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I59c420c03a8f01d185f616a2212798266b4251e0
Gerrit-Change-Number: 83986
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Simon Yang
simon1.yang@intel.com
Gerrit-Comment-Date: Wed, 21 Aug 2024 01:40:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com