Attention is currently required from: Alexander Couzens, Maciej Pijanowski, Michał Kopeć, Paul Menzel.
Angel Pons has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/coreboot/+/80609?usp=email )
Change subject: mb/lenovo: Add ThinkCentre M920q (Coffee Lake)
......................................................................
Patch Set 10: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80609/comment/8330c64d_6791687d?usp... :
PS10, Line 26: - PCIe x8 port
Tested by `dnssound.` on the coreboot Discord using a `BA7H70 Rev 1.2` riser and an Intel `X540-T2 10G` dual 10GbE card (PCIe x8).
What remains untested, however, is a different riser with a PCIe x4 connector. On that riser, the PCIe lanes come from the PCH for some reason.
File src/mainboard/lenovo/m920q/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80609/comment/04fbc778_3de0847f?usp... :
PS7, Line 15: device ref peg0 on end # Slot JP3 - not tested
Done
Update: The `BA7H70 Rev 1.2` riser works properly
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80609?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iea1dc5745c0ecf687fa18b793f0aab4b0855d6d4
Gerrit-Change-Number: 80609
Gerrit-PatchSet: 10
Gerrit-Owner: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Sat, 22 Jun 2024 10:49:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com