[L] Change in coreboot[main]: soc/mediatek/common: Move common GPIO definitions to gpio_defs.h - coreboot-gerrit

7 Sep 2024


      Attention is currently required from: Hung-Te Lin, Xi Chen, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84221?usp=email )
Change subject: soc/mediatek/common: Move common GPIO definitions to gpio_defs.h
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/common/include/soc/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/84221/comment/03cc1344_4c416ec3?usp... :
PS1, Line 37: val_regs
...
Can we rename it to `gpio_val_regs`?
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84221?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If35dcc4d88732f92c7c43a5eed0478ec52cf1802
Gerrit-Change-Number: 84221
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Xi Chen xixi.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Sat, 07 Sep 2024 01:07:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com