Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57140 )
Change subject: soc/tigerlake: Make IO decode / enable register configurable
......................................................................
Patch Set 19:
(1 comment)
Patchset:
PS19:
Tbh I wouldn't do that for each platform but keep using common code, since it handles mirroring alre […]
I just wanted to show that it can be much simpler. For instance, we could
call lpc_set_fixed_io_ranges() and lpc_enable_fixed_io_ranges() with static
values from platform code. It's all the `if` and `else` and (likely unneces-
sary) mainboard overrides that concern me.
If we ever can confirm that a single set (e.g. enable everything) works for
all boards, we could even move the calls to common code.
`gen_io_dec` is a separate topic.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57140
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1a7f2707e565a5651ebe438320de9597f5742c3
Gerrit-Change-Number: 57140
Gerrit-PatchSet: 19
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 08 Oct 2021 13:02:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment