Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80102?usp=email )
Change subject: soc/intel/xeon_sp: Drop code to locate the UBOX bus
......................................................................
Patch Set 9:
(3 comments)
File src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h:
https://review.coreboot.org/c/coreboot/+/80102/comment/24d6c10e_378c610e :
PS9, Line 27: uint8_t get_stack_busno(const uint8_t stack);
the wording 'stack' might be confused, can we use below instead?
get_socket_ubox_busno(socket, func)?
File src/soc/intel/xeon_sp/spr/soc_util.c:
https://review.coreboot.org/c/coreboot/+/80102/comment/b927af8f_9e086bcb :
PS9, Line 142: uint32_t get_ubox_busno(uint32_t socket, uint8_t offset)
it is still needed to do per-socket uncore bus operations as a general case so it would make sense to keep
File src/soc/intel/xeon_sp/util.c:
https://review.coreboot.org/c/coreboot/+/80102/comment/11b79bc5_384683de :
PS9, Line 27:
The words STACK is confusing, can we use UNCORE_BUS_1 directly? or UNCORE_PCU instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80102?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2b18f02f62b69ec7c73cd5665102cb6bfc6e64b5
Gerrit-Change-Number: 80102
Gerrit-PatchSet: 9
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 02 Feb 2024 05:14:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment