Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57747 )
Change subject: amdfwtool: Add ISH header support for A/B recovery layout
......................................................................
Patch Set 32:
(2 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/57747/comment/7a6cd9e1_83813563
PS24, Line 662: 0xf
the specification i'm looking says that this should be 1
Not sure. Copied from CRB
https://review.coreboot.org/c/coreboot/+/57747/comment/0ec65373_ef454180
PS24, Line 751: 4096
not directly related to this patch, but it would also be good to use ERASE_ALIGNMENT or TABLE_ALIGNM […]
Done
https://review.coreboot.org/c/coreboot/+/59383
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57747
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0690cde1dce949514c7aacebe13096b7814ceff
Gerrit-Change-Number: 57747
Gerrit-PatchSet: 32
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bao Zheng
zheng.bao@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 17 Nov 2021 08:00:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment