Attention is currently required from: Hung-Te Lin, Vadim Bendebury, Furquan Shaikh, Mathew King.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57864 )
Change subject: guybrush: add RO_GSCVD area to FMAP
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/57864/comment/1c777760_b238015d
PS1, Line 29: RO_GSCVD 8K
Whole (except GBB) RO_SECTION will be updated during firmware update (if WP is disabled) so I'd also […]
RO_VPD will not be part of the things that are verified by GSCVD, so I don't think that extra container is necessary.
However, when updating RO firmware the GSCVD section also needs to be replaced with the new one from the updater image. Does the updater actually care about RO_SECTION? I thought it just flashes the whole image minus explicitly excluded sections (like RO_VPD), right?
As for where to put it, anywhere it fits really (for this board, both at the beginning of WP_RO and between RO_VPD and RO_SECTION sound fine).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57864
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa24d5a6271a8bcbf737d4580ec85b9cfdd9af01
Gerrit-Change-Number: 57864
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Comment-Date: Fri, 01 Oct 2021 02:22:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Vadim Bendebury
vbendeb@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment