Attention is currently required from: Kevin Chiu, Raul Rangel, Rob Barnes. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59053 )
Change subject: mb/google/guybrush: Make GPIO_69 default for SD_AUX_RESET_L ......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/guybrush/variants/guybrush/gpio.c:
https://review.coreboot.org/c/coreboot/+/59053/comment/086825d1_4b78028c PS2, Line 57: /* This table is used by guybrush variant with board version >= 2. */ : static const struct soc_amd_gpio bid2_pcie_gpio_table[] = { : }; : Nit: Empty table can be removed and NULL can be returned for bid >= 2.
File src/mainboard/google/guybrush/variants/nipperkin/gpio.c:
https://review.coreboot.org/c/coreboot/+/59053/comment/c0f26e23_affb9d6e PS2, Line 51: PAD_NC(GPIO_69), Can be removed as well and then bid1_override_pcie_gpio_table can be consolidated with bid2_override_pcie_gpio_table.