[S] Change in coreboot[master]: cpu/x86/smm/module_loader: Fix ASEG loading - coreboot-gerrit

11 Nov 2022


      Attention is currently required from: Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69233 )
Change subject: cpu/x86/smm/module_loader: Fix ASEG loading
......................................................................
Patch Set 4:
(1 comment)
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/69233/comment/2c5a3a90_29fce207 
PS4, Line 444: 	const size_t fx_save_area_size = CONFIG(SSE) ? FXSAVE_SIZE * params->num_cpus : 0;
We currently have these:
CFLAGS_x86_64 += -march=nocona
  CFLAGS_x86_32 += -march=i686
Even if we set SSE=y, x86_32 compiler will not use MMX or XMM registers, and fxsave could be skipped?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69233
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45355efb274c6ddd09a6fb57743d2f6a5b53d209
Gerrit-Change-Number: 69233
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 11 Nov 2022 16:46:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment