Attention is currently required from: Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74370?usp=email )
Change subject: soc/intel/meteorlake: Replace assert with error message
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
asserts are not failing boot by default and are more appropriate than error messages. Even when asserts are halting boot, they pinpoint you to an issue. With error messages you can have many other ones and debugging is harder.
the point here is that, we don't want to boot halt the device (like what asset does) as any such UPD misalignment is not a boot critical failure.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74370?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49a988b7eda009456d438ba7be0d2918826e1c36
Gerrit-Change-Number: 74370
Gerrit-PatchSet: 5
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Thu, 15 Feb 2024 17:27:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment