Attention is currently required from: Jérémy Compostella, yuchi.chen@intel.com.
Shuo Liu has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83317?usp=email )
Change subject: soc/intel/common/block/gpmr: allow soc to have specific gpmr definition
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/gpmr.h:
https://review.coreboot.org/c/coreboot/+/83317/comment/5d62ec20_34d9d071?usp... :
PS3, Line 10: #include <soc/gpmr.h>
Is these GPMR as additional sets based on ioc_gpmr or pcr_gpmr?
If yes, we could add soc/gpmr.h outside of the if branch?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83317?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I94797a72af75fc96ab2cacb1d46b581605a15387
Gerrit-Change-Number: 83317
Gerrit-PatchSet: 3
Gerrit-Owner: yuchi.chen@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Thu, 04 Jul 2024 02:24:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No