Change in coreboot[master]: cbfstool: Do host space address conversion earlier when adding files
Attention is currently required from: Raul Rangel, Patrick Georgi, Tim Wawrzynczak. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60018 )
Change subject: cbfstool: Do host space address conversion earlier when adding files ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60018/comment/ca24bcbd_5ef3d8c2 PS2, Line 23: no effect
Can we remove it from the Makefiles?
Well, the --base-address is always passed, but the --topswap-size is optional depending on Kconfigs. I think the easiest option is to leave things as they are.
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/60018/comment/3f312835_24c31046 PS2, Line 1074: 4*1024;
Just curious if you know why the 4K requirement?
No, you'll have to ask the people working on Intel stuff. It has something to do with that FSP relocation thing that I haven't really looked into.
https://review.coreboot.org/c/coreboot/+/60018/comment/f850485f_0c34a302 PS2, Line 1078: offset
Isn't `address` supposed to contain a host based address so it can perform the relocation?
Oh crap. Yeah, sorry, I totally misread the code. Let me rethink if this patch makes sense then...
-
Julius Werner (Code Review)