Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84013?usp=email )
Change subject: libpayload: Fix x86 output arch
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS4:
Actually, we do. I'm just getting the weirdest output (a lot of #define).
Turned out to be the `-ggdb3` in the command line. Newer `ld` seems to ignore
the `#` lines, though. So shouldn't be an issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84013?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0f134a96c596d69e10dd441b96184b119e9f1908
Gerrit-Change-Number: 84013
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 27 Aug 2024 13:01:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de