[L] Change in coreboot[main]: mb/google/fatcat: Add override tree

[Pranava Y N (Code Review)]

Attention is currently required from: Jérémy Compostella.

Pranava Y N has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84407?usp=email )

Change subject: mb/google/fatcat: Add override tree
......................................................................

Patch Set 1:

(10 comments)

File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/84407/comment/545d2e8e_8f0cccf6?usp... :
PS1, Line 28: register "usb2_port_reset_msg_en[0]" = "1"
            : 	register "usb2_port_reset_msg_en[1]" = "1"
            : 	register "usb2_port_reset_msg_en[2]" = "1"
            : 	register "usb2_port_reset_msg_en[3]" = "1"
Please let me know what this register is. We have not used this before.

https://review.coreboot.org/c/coreboot/+/84407/comment/f253d8f4_d2029bac?usp... :
PS1, Line 40: 
            : 	register "tcss_cap_policy[0]" = "7"
            : 	register "tcss_cap_policy[1]" = "7"
            : 	register "tcss_cap_policy[2]" = "7"
            : 	register "tcss_cap_policy[3]" = "7"
Please let me know what this is.

https://review.coreboot.org/c/coreboot/+/84407/comment/4e1fb29d_823a5685?usp... :
PS1, Line 63: DDI_ENABLE_DDC
Is this required to be enabled?

https://review.coreboot.org/c/coreboot/+/84407/comment/1198d151_ad91a9fe?usp... :
PS1, Line 79: 	[PchSerialIoIndexI2C4]  = PchSerialIoPci,
Disable these as I2C0 and I2C4 are not used?

https://review.coreboot.org/c/coreboot/+/84407/comment/f8ac5544_b96f1315?usp... :
PS1, Line 151: 		device ref dtt off end
             : 		device ref npu on end
             : 		device ref iaa off end
             : 
             : 		device ref heci1 on end
             : 
you can move these to baseboard

https://review.coreboot.org/c/coreboot/+/84407/comment/4e7b65d4_2fb73557?usp... :
PS1, Line 157: device ref thc0 on end
Please confirm if we are using this

https://review.coreboot.org/c/coreboot/+/84407/comment/516664fa_b3651cbd?usp... :
PS1, Line 335: device ref xhci on
NOT IMPORTANT: It would be better to put this block right after tcss_dma

https://review.coreboot.org/c/coreboot/+/84407/comment/dd8217a2_04f06da8?usp... :
PS1, Line 339: 						register "desc" = ""USB2 Type-A Port 1""
             : 						register "type" = "UPC_TYPE_A"
             : 						register "group" = "ACPI_PLD_GROUP(1, 1)"
             : 						device ref usb2_port1 on end
             : 					end
             : 					chip drivers/usb/acpi
             : 						register "desc" = ""USB2 Type-A Port 2""
             : 						register "type" = "UPC_TYPE_A"
             : 						register "group" = "ACPI_PLD_GROUP(2, 1)"
             : 						device ref usb2_port2 on end
             : 					end
             : 					chip drivers/usb/acpi
             : 						register "desc" = ""USB2 Type-A Port 3""
             : 						register "type" = "UPC_TYPE_A"
             : 						register "group" = "ACPI_PLD_GROUP(3, 1)"
             : 						device ref usb2_port3 on end
             : 					end
             : 					chip drivers/usb/acpi
             : 						register "desc" = ""USB2 Type-A Port 4""
             : 						register "type" = "UPC_TYPE_A"
             : 						register "group" = "ACPI_PLD_GROUP(4, 1)"
             : 						device ref usb2_port4 on end
             : 					end
Ports 1-4 are used for Type-C right? Please change these to map correctly.

https://review.coreboot.org/c/coreboot/+/84407/comment/8252470f_d7d803db?usp... :
PS1, Line 363: Port 5"
Port 1

https://review.coreboot.org/c/coreboot/+/84407/comment/736dc24a_9eee95f9?usp... :
PS1, Line 369: Port 6"
Port 2