Change in coreboot[master]: mb/google/drallion: Remove touch screen detect.

[JoeJ Chang (Code Review)]

JoeJ Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35644 )

Change subject: mb/google/drallion: Remove touch screen detect.
......................................................................

mb/google/drallion: Remove touch screen detect.

GPP_B4 is always high due to the cable issue, remove the
HW strap detect temporarily.

BUG=b:141722840

Signed-off-by: JoeJ Chang 
Change-Id: I8781f36d87ece1980137cddde9fe2b6e3f3d5636
---
M src/mainboard/google/drallion/variants/drallion/devicetree.cb
1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/35644/1

diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb
index d824a55..89e2df8 100644
--- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb
+++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb
@@ -344,8 +344,6 @@
    			register "generic.enable_delay_ms" = "55"
    			register "generic.has_power_resource" = "1"
    			register "hid_desc_reg_offset" = "0x01"
-				register "generic.device_present_gpio" = "GPP_B4"
-				register "generic.device_present_gpio_invert" = "1"
    			device i2c 10 on end
    		end
    		chip drivers/i2c/generic
@@ -358,8 +356,6 @@
    			register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)"
    			register "enable_delay_ms" = "55"
    			register "has_power_resource" = "1"
-				register "device_present_gpio" = "GPP_B4"
-				register "device_present_gpio_invert" = "1"
    			device i2c 34 on end
    		end
    	end # I2C #0

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35644 )

Change subject: mb/google/drallion: Remove touch screen detect.
......................................................................

Patch Set 1: Code-Review+1

This is a WA for cable issue.

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35644 )

Change subject: mb/google/drallion: Remove touch screen detect.
......................................................................

Patch Set 1: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35644 )

Change subject: mb/google/drallion: Remove touch screen detect.
......................................................................

Patch Set 1:

I will let Matthew +2 this.

[Bora Guvendik (Code Review)]

Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35644 )

Change subject: mb/google/drallion: Remove touch screen detect.
......................................................................

Patch Set 1: Code-Review+2

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35644 )

Change subject: mb/google/drallion: Remove touch screen detect.
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35644 )

Change subject: mb/google/drallion: Remove touch screen detect.
......................................................................

Patch Set 1:

Mathew, is this good to go in?

[Mathew King (Code Review)]

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35644 )

Change subject: mb/google/drallion: Remove touch screen detect.
......................................................................

Patch Set 2:
> Patch Set 1:
>
> Mathew, is this good to go in?

Bora, does this need to be submitted or not?

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35644 )

Change subject: mb/google/drallion: Remove touch screen detect.
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35644/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35644/2//COMMIT_MSG@7 
PS2, Line 7: mb/google/drallion: Remove touch screen detect.
Please remove the dot/period at the end of the commit message summary.

[Bora Guvendik (Code Review)]

Bora Guvendik has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/35644 )

Change subject: mb/google/drallion: Remove touch screen detect.
......................................................................

Removed Code-Review+2 by Bora Guvendik

[Bora Guvendik (Code Review)]

Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35644 )

Change subject: mb/google/drallion: Remove touch screen detect.
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 1:
> >
> > Mathew, is this good to go in?
>
> Bora, does this need to be submitted or not?

Mat, it seems we don't need it.

Change in coreboot[master]: mb/google/drallion: Remove touch screen detect

[EricR Lai (Code Review)]

EricR Lai has uploaded a new patch set (#3) to the change originally created by JoeJ Chang. ( https://review.coreboot.org/c/coreboot/+/35644 )

Change subject: mb/google/drallion: Remove touch screen detect
......................................................................

mb/google/drallion: Remove touch screen detect

GPP_B4 is always high due to the cable issue, remove the
HW strap detect temporarily.

BUG=b:141722840

Signed-off-by: JoeJ Chang 
Change-Id: I8781f36d87ece1980137cddde9fe2b6e3f3d5636
---
M src/mainboard/google/drallion/variants/drallion/devicetree.cb
1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/35644/3

Change in coreboot[master]: mb/google/drallion: Remove touch screen detect

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35644 )

Change subject: mb/google/drallion: Remove touch screen detect
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35644/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35644/2//COMMIT_MSG@7 
PS2, Line 7: mb/google/drallion: Remove touch screen detect.
> Please remove the dot/period at the end of the commit message summary.

Done

Change in coreboot[master]: mb/google/drallion: Remove touch screen detect

[JoeJ Chang (Code Review)]

JoeJ Chang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35644 )

Change subject: mb/google/drallion: Remove touch screen detect
......................................................................

Abandoned