Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60149 )
Change subject: mb/google/reef: Drop unnecessary option ......................................................................
mb/google/reef: Drop unnecessary option
Since all variants select the option `BASEBOARD_REEF_LAPTOP`, drop it and let the common baseboard option select it.
Change-Id: I7f2ffd1e7b9ad2fab500b83c4cc56c9fc2d161ab Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/60149 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/reef/Kconfig 1 file changed, 2 insertions(+), 11 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index a4bd882..b0d0508 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -20,38 +20,29 @@ select MAINBOARD_HAS_TPM2 select SAR_ENABLE select SOC_INTEL_APOLLOLAKE + select SYSTEM_TYPE_LAPTOP select USE_SAR
config BOARD_GOOGLE_REEF - select BASEBOARD_REEF_LAPTOP select BOARD_GOOGLE_BASEBOARD_REEF
config BOARD_GOOGLE_PYRO - select BASEBOARD_REEF_LAPTOP select BOARD_GOOGLE_BASEBOARD_REEF
config BOARD_GOOGLE_SAND - select BASEBOARD_REEF_LAPTOP select BOARD_GOOGLE_BASEBOARD_REEF
config BOARD_GOOGLE_SNAPPY - select BASEBOARD_REEF_LAPTOP select BOARD_GOOGLE_BASEBOARD_REEF
config BOARD_GOOGLE_NASHER - select BASEBOARD_REEF_LAPTOP select BOARD_GOOGLE_BASEBOARD_REEF
config BOARD_GOOGLE_CORAL - select BASEBOARD_REEF_LAPTOP select BOARD_GOOGLE_BASEBOARD_REEF
if BOARD_GOOGLE_BASEBOARD_REEF
-config BASEBOARD_REEF_LAPTOP - def_bool n - select SYSTEM_TYPE_LAPTOP - config DRIVER_TPM_I2C_BUS hex default 0x2 @@ -67,7 +58,7 @@ config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES select HAS_RECOVERY_MRC_CACHE - select VBOOT_LID_SWITCH if BASEBOARD_REEF_LAPTOP + select VBOOT_LID_SWITCH
config MAINBOARD_DIR default "google/reef"