Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46732 )
Change subject: soc/intel/broadwell/gma.c: Align struct with Haswell ......................................................................
soc/intel/broadwell/gma.c: Align struct with Haswell
Change-Id: Ifd1fb02497e1d326b6b9c5752f471f52b145a8ef Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/gma.c 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/46732/1
diff --git a/src/soc/intel/broadwell/gma.c b/src/soc/intel/broadwell/gma.c index 3889be3..d42eebc 100644 --- a/src/soc/intel/broadwell/gma.c +++ b/src/soc/intel/broadwell/gma.c @@ -588,12 +588,12 @@ }
static struct device_operations igd_ops = { - .read_resources = &pci_dev_read_resources, - .set_resources = &pci_dev_set_resources, - .enable_resources = &pci_dev_enable_resources, - .init = &igd_init, - .ops_pci = &pci_dev_ops_pci, + .read_resources = pci_dev_read_resources, + .set_resources = pci_dev_set_resources, + .enable_resources = pci_dev_enable_resources, + .init = igd_init, .acpi_fill_ssdt = gma_generate_ssdt, + .ops_pci = &pci_dev_ops_pci, };
static const unsigned short pci_device_ids[] = {
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46732
to look at the new patch set (#2).
Change subject: soc/intel/broadwell/gma.c: Align struct with Haswell ......................................................................
soc/intel/broadwell/gma.c: Align struct with Haswell
Change-Id: Ifd1fb02497e1d326b6b9c5752f471f52b145a8ef Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/gma.c 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/46732/2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46732 )
Change subject: soc/intel/broadwell/gma.c: Align struct with Haswell ......................................................................
Patch Set 8: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46732 )
Change subject: soc/intel/broadwell/gma.c: Align struct with Haswell ......................................................................
Patch Set 8: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46732 )
Change subject: soc/intel/broadwell/gma.c: Align struct with Haswell ......................................................................
soc/intel/broadwell/gma.c: Align struct with Haswell
Change-Id: Ifd1fb02497e1d326b6b9c5752f471f52b145a8ef Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46732 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Nico Huber nico.h@gmx.de --- M src/soc/intel/broadwell/gma.c 1 file changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Michael Niewöhner: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/broadwell/gma.c b/src/soc/intel/broadwell/gma.c index 3889be3..d42eebc 100644 --- a/src/soc/intel/broadwell/gma.c +++ b/src/soc/intel/broadwell/gma.c @@ -588,12 +588,12 @@ }
static struct device_operations igd_ops = { - .read_resources = &pci_dev_read_resources, - .set_resources = &pci_dev_set_resources, - .enable_resources = &pci_dev_enable_resources, - .init = &igd_init, - .ops_pci = &pci_dev_ops_pci, + .read_resources = pci_dev_read_resources, + .set_resources = pci_dev_set_resources, + .enable_resources = pci_dev_enable_resources, + .init = igd_init, .acpi_fill_ssdt = gma_generate_ssdt, + .ops_pci = &pci_dev_ops_pci, };
static const unsigned short pci_device_ids[] = {
-
Angel Pons (Code Review) -
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)