[M] Change in coreboot[main]: soc/intel/cse: Add function to get cse_bp_info early

[Krishna P Bhat D (Code Review)]

Attention is currently required from: Anil Kumar K, Rizwan Qureshi, Subrata Banik.

Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78053?usp=email )

Change subject: soc/intel/cse: Add function to get cse_bp_info early
......................................................................

Patch Set 3:

(6 comments)

Patchset:

PS1:
> this cl should combine w/ CB:78052

Done

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/78053/comment/24529a41_9f20bb7d :
PS1, Line 466: is_memory_initialized
> nit: This was in anticipation of a future call to this function post FSP-M as part of the cbmem init […]

Done

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/78053/comment/4c37d285_7679ceda :
PS2, Line 424: store_cse_bp_info_in_cbmem
>

store_cse_bp_info_in_cbmem() is being called by https://review.coreboot.org/c/coreboot/+/78053/2/src/soc/intel/common/block/... to store response in the case of late romstage cse_fw_sync() and also called by https://review.coreboot.org/c/coreboot/+/78053/2/src/soc/intel/common/block/... in CBMEM_CREATION_HOOK. 
cbmem_find(CBMEM_ID_CSE_BP_INFO) is only used at https://review.coreboot.org/c/coreboot/+/78053/2/src/soc/intel/common/block/..., better not to move it to common function.

https://review.coreboot.org/c/coreboot/+/78053/comment/3cc0b81a_bf9364a8 :
PS2, Line 469: cbmem_find(CBMEM_ID_CSE_BP_INFO)
> fetch_cse_bp_info_from_cbmem();

cbmem_find(CBMEM_ID_CSE_BP_INFO) is used only in this case, so better not to move it to common function.

https://review.coreboot.org/c/coreboot/+/78053/comment/675ac49b_5eba1af9 :
PS2, Line 470: cse_bp_info_in_cbmem
> add a check if cse_bp_info_in_cbmem!=NULL and data returned from CBMEM ID is also authentic (https:/ […]

https://review.coreboot.org/c/coreboot/+/78053/comment/2f9f5241_046c81c8/ As Rizwan suggested.

https://review.coreboot.org/c/coreboot/+/78053/comment/f533aa5b_a145d58d :
PS2, Line 507: 	if (cbmem_online())
             : 		store_cse_bp_info_in_cbmem();
> i don't think we need this check now, fetch_cse_bp_info_from_cbmem() can add the entry for CBMEM_ID_ […]

We have to consider the case of cse_fw_sync() being called in late romstage also like in JSL, TGL. The cbmem init hooks would have been run prior to cse_get_bp_info being called (after fsp memory init) and we would have to then copy the get_bp_info_rsp to cbmem.