Attention is currently required from: Felix Singer.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74328 )
Change subject: device: Correct D3Cold Kconfig option
......................................................................
Patch Set 2:
(1 comment)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/74328/comment/5ef8f4bf_b13c6e2c
PS2, Line 1007: config D3COLD_SUPPORT
I might be blind but I am missing *WHY* CB:73042 adds these options. […]
so that there is one "thing" that configures fsp, acpi and rtd3 acpi
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74328
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9bdb6589e98ac81d0ce25df52fb916b5c2fd0157
Gerrit-Change-Number: 74328
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Wed, 12 Apr 2023 05:08:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment