[M] Change in coreboot[master]: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS
Attention is currently required from: Michał Żygowski, Paul Menzel, Angel Pons.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64639 )
Change subject: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS ......................................................................
Patch Set 11:
(3 comments)
File src/drivers/generic/cbfs-uuid/cbfs-uuid.c:
https://review.coreboot.org/c/coreboot/+/64639/comment/1fb0d68f_d9e24e5d PS9, Line 11: char uuid_str[UUID_STRLEN + 1] = {0};
Done, please check.
Done
File src/drivers/generic/cbfs-uuid/cbfs-uuid.c:
https://review.coreboot.org/c/coreboot/+/64639/comment/472758b2_9eef42cf PS10, Line 18: obsolete
Done
Done
File src/drivers/generic/cbfs-uuid/cbfs-uuid.c:
https://review.coreboot.org/c/coreboot/+/64639/comment/49fa7e4b_50ee6305 PS11, Line 11: /* Add 3 more bytes (2 for possible CRLF) and third for NULL char */ Parentheses seems misplaced, how about `Add 3 more bytes: 2 for possible CRLF and third for NULL char`
I know, I'm nit-picking 😊
-
Krystian Hebel (Code Review)