Attention is currently required from: Marc Jones, Stefan Reinauer, Julius Werner, Patrick Rudolph.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45208 )
Change subject: console: Allow configuring log level through CBFS
......................................................................
Patch Set 17:
(1 comment)
File tests/console/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45208/comment/b1b9e418_80635c36
PS14, Line 10: routing-with-cbmemcons-test-cflags += -I 3rdparty/vboot/firmware/include
I still don't really understand this. […]
Same include path for which architecture and chipset? The test system can draw in very precise combinations because that way it can emulate whatever environment is needed.
I _suppose_ one could make the case that with the vboot code used in cbfs it's pretty much universally required and therefore should become part of the default search path for unit tests, but that's a slightly different conversation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45208
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f1f5c45e5ea889176d04e0db438ca2aa7c536ee
Gerrit-Change-Number: 45208
Gerrit-PatchSet: 17
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Greg Edelston
gredelston@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 14 Jul 2021 21:31:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment