Attention is currently required from: Cliff Huang, Lance Zhao, Subrata Banik, Subrata Banik, Tim Wawrzynczak.
David Ruth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80170?usp=email )
Change subject: Add MTCL function to ACPI SSDT tables ......................................................................
Patch Set 5:
(4 comments)
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/80170/comment/a200e2c1_7bb1c757 : PS3, Line 4788:
nit: tab may be
It looks like it's usually 2 tabs, so I went with that.
File src/include/mtcl.h:
https://review.coreboot.org/c/coreboot/+/80170/comment/fc7b2727_cb9b259c : PS3, Line 1: #ifndef _MTCL_H_
nit: keep this as header for the new file […]
Done
File src/vendorcode/google/chromeos/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/80170/comment/2cf968fb_beec27e6 : PS3, Line 11: ramstage-$(CONFIG_USE_MTCL) += mtcl.c
nit: before line 10
Done
File src/vendorcode/google/chromeos/mtcl.c:
https://review.coreboot.org/c/coreboot/+/80170/comment/a8140ef0_43f2e507 : PS3, Line 1: #include <cbfs.h>
keep this as the first line\ […]
Done