[M] Change in coreboot[master]: soc/intel/cmd/block: Implement an API to get firmware partition details

[Paul Menzel (Code Review)]

Attention is currently required from: Haribalaraman Ramasubramanian, Dinesh Gehlot, Rizwan Qureshi, Reka Norman.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 )

Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details
......................................................................

Patch Set 27:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/74005/comment/97b2cd13_80163df6 
PS27, Line 9: FPT
Firmware Partition T? or is it PT for partition?

File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/74005/comment/a552f994_35151045 
PS27, Line 1242: 		printk(BIOS_ERR, "HECI: Prerequisites not met for fw partition request\n");
For debugging it might be easier to check each condition separately, and log what condition failed. (Or do the called functions log messages themselves?)

https://review.coreboot.org/c/coreboot/+/74005/comment/79dce86c_1c4b75af 
PS27, Line 1250: resp->hdr.result
Is `resp->hdr.result` always set?

https://review.coreboot.org/c/coreboot/+/74005/comment/070ac016_e5e4752c 
PS27, Line 1260: 		printk(BIOS_INFO, "CSE: Info request denied, recovery mode or no CSE LITE SKU\n");
To help debugging an issue, I’d log a dedicated message for each condition.