[S] Change in coreboot[main]: skl mainboards: Move cpu_cluster device to chipset devicetree
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83161?usp=email )
Change subject: skl mainboards: Move cpu_cluster device to chipset devicetree ......................................................................
skl mainboards: Move cpu_cluster device to chipset devicetree
Change-Id: I7114612e686a0bf3cfc241f45fa62077fad16f5a Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/51nb/x210/devicetree.cb M src/mainboard/acer/aspire_vn7_572g/devicetree.cb M src/mainboard/asrock/h110m/devicetree.cb M src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb M src/mainboard/facebook/monolith/devicetree.cb M src/mainboard/google/eve/devicetree.cb M src/mainboard/google/fizz/variants/baseboard/devicetree.cb M src/mainboard/google/glados/devicetree.cb M src/mainboard/google/poppy/variants/atlas/devicetree.cb M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/devicetree.cb M src/mainboard/google/poppy/variants/nocturne/devicetree.cb M src/mainboard/google/poppy/variants/rammus/devicetree.cb M src/mainboard/google/poppy/variants/soraka/devicetree.cb M src/mainboard/hp/280_g2/devicetree.cb M src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb M src/mainboard/intel/kblrvp/variants/rvp7/overridetree.cb M src/mainboard/intel/kunimitsu/devicetree.cb M src/mainboard/intel/saddlebrook/devicetree.cb M src/mainboard/kontron/bsl6/devicetree.cb M src/mainboard/lenovo/m900_tiny/devicetree.cb M src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb M src/mainboard/libretrend/lt1000/devicetree.cb M src/mainboard/protectli/vault_kbl/devicetree.cb M src/mainboard/purism/librem_skl/devicetree.cb M src/mainboard/razer/blade_stealth_kbl/devicetree.cb M src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb M src/mainboard/supermicro/x11-lga1151-series/devicetree.cb M src/mainboard/system76/kbl-u/devicetree.cb M src/soc/intel/skylake/chipset.cb 31 files changed, 1 insertion(+), 33 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/83161/1
diff --git a/src/mainboard/51nb/x210/devicetree.cb b/src/mainboard/51nb/x210/devicetree.cb index 2695451..b25e357 100644 --- a/src/mainboard/51nb/x210/devicetree.cb +++ b/src/mainboard/51nb/x210/devicetree.cb @@ -100,7 +100,6 @@ # Send an extra VR mailbox command for the PS4 exit issue register "SendVrMbxCmd" = "2"
- device cpu_cluster 0 on end device domain 0 on device ref igpu on end device ref sa_thermal on end diff --git a/src/mainboard/acer/aspire_vn7_572g/devicetree.cb b/src/mainboard/acer/aspire_vn7_572g/devicetree.cb index 0328ec7..0b590ae 100644 --- a/src/mainboard/acer/aspire_vn7_572g/devicetree.cb +++ b/src/mainboard/acer/aspire_vn7_572g/devicetree.cb @@ -32,7 +32,6 @@ [PchSerialIoIndexUart2] = PchSerialIoSkipInit, }"
- device cpu_cluster 0 on end device domain 0 on subsystemid 0x1025 0x1037 inherit device ref system_agent on diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb index a6d16f9..92e4ba7 100644 --- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -41,7 +41,6 @@ # Send an extra VR mailbox command for the PS4 exit issue register "SendVrMbxCmd" = "2"
- device cpu_cluster 0 on end device domain 0 on device ref system_agent on subsystemid 0x1849 0x191f diff --git a/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb b/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb index 765d17c..cb6d409 100644 --- a/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb +++ b/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb @@ -35,7 +35,6 @@ [PchSerialIoIndexUart2] = PchSerialIoSkipInit, // LPSS UART }"
- device cpu_cluster 0 on end device domain 0 on subsystemid 0x1558 0x1313 inherit device ref system_agent on end diff --git a/src/mainboard/facebook/monolith/devicetree.cb b/src/mainboard/facebook/monolith/devicetree.cb index 3f71ca9..fdb59c9 100644 --- a/src/mainboard/facebook/monolith/devicetree.cb +++ b/src/mainboard/facebook/monolith/devicetree.cb @@ -214,7 +214,6 @@ [PchSerialIoIndexUart2] = PchSerialIoDisabled, }"
- device cpu_cluster 0 on end device domain 0 on device ref igpu on end device ref sa_thermal on end diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb index dfa7a6e..8b4718d 100644 --- a/src/mainboard/google/eve/devicetree.cb +++ b/src/mainboard/google/eve/devicetree.cb @@ -228,7 +228,6 @@ }" register "tcc_offset" = "10"
- device cpu_cluster 0 on end device domain 0 on device ref igpu on end device ref sa_thermal on end diff --git a/src/mainboard/google/fizz/variants/baseboard/devicetree.cb b/src/mainboard/google/fizz/variants/baseboard/devicetree.cb index 44fc014..ec11060 100644 --- a/src/mainboard/google/fizz/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/fizz/variants/baseboard/devicetree.cb @@ -305,7 +305,6 @@ }" register "tcc_offset" = "6" # TCC of 94C
- device cpu_cluster 0 on end device domain 0 on device ref igpu on end device ref sa_thermal on end diff --git a/src/mainboard/google/glados/devicetree.cb b/src/mainboard/google/glados/devicetree.cb index 58b421c..2c34beb 100644 --- a/src/mainboard/google/glados/devicetree.cb +++ b/src/mainboard/google/glados/devicetree.cb @@ -81,7 +81,6 @@ # Send an extra VR mailbox command for the PS4 exit issue register "SendVrMbxCmd" = "2"
- device cpu_cluster 0 on end device domain 0 on device ref igpu on end device ref sa_thermal on end diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index eb7d660..e522041 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -227,7 +227,6 @@ [PchSerialIoIndexUart2] = PchSerialIoSkipInit, }"
- device cpu_cluster 0 on end device domain 0 on device ref system_agent on end device ref igpu on end diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb index 2425de2..cfeefb1 100644 --- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb @@ -249,7 +249,6 @@ # Use default SD card detect GPIO configuration register "sdcard_cd_gpio" = "GPP_E15"
- device cpu_cluster 0 on end device domain 0 on device ref system_agent on end device ref igpu on end diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index 334250e..e5cbdcc 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -273,7 +273,6 @@ .psys_pmax = 101, }"
- device cpu_cluster 0 on end device domain 0 on device ref system_agent on end device ref igpu on end diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb index 4cbc045..ad22c77 100644 --- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb @@ -280,7 +280,6 @@ # Use default SD card detect GPIO configuration register "sdcard_cd_gpio" = "GPP_E15"
- device cpu_cluster 0 on end device domain 0 on device ref system_agent on end device ref igpu on end diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 188f0e1..7c0abc1 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -244,7 +244,6 @@ [PchSerialIoIndexUart2] = PchSerialIoSkipInit, }"
- device cpu_cluster 0 on end device domain 0 on device ref system_agent on end device ref igpu on end diff --git a/src/mainboard/google/poppy/variants/rammus/devicetree.cb b/src/mainboard/google/poppy/variants/rammus/devicetree.cb index 34dd2af..dce0a89 100644 --- a/src/mainboard/google/poppy/variants/rammus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/rammus/devicetree.cb @@ -230,7 +230,6 @@ # Use default SD card detect GPIO configuration register "sdcard_cd_gpio" = "GPP_E15"
- device cpu_cluster 0 on end device domain 0 on device ref system_agent on end device ref igpu on end diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb index d642137..feaa775 100644 --- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb +++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb @@ -259,7 +259,6 @@ # Use default SD card detect GPIO configuration register "sdcard_cd_gpio" = "GPP_E15"
- device cpu_cluster 0 on end device domain 0 on device ref system_agent on end device ref igpu on end diff --git a/src/mainboard/hp/280_g2/devicetree.cb b/src/mainboard/hp/280_g2/devicetree.cb index 3b25a42..74780d0 100644 --- a/src/mainboard/hp/280_g2/devicetree.cb +++ b/src/mainboard/hp/280_g2/devicetree.cb @@ -7,7 +7,6 @@
register "eist_enable" = "1"
- device cpu_cluster 0 on end device domain 0 on subsystemid 0x103c 0x2b5e inherit device ref peg0 on end diff --git a/src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb b/src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb index b282657..b57deff 100644 --- a/src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb +++ b/src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb @@ -109,7 +109,6 @@ # Send an extra VR mailbox command for the PS4 exit issue register "SendVrMbxCmd" = "2"
- device cpu_cluster 0 on end device domain 0 on device ref igpu on end device ref sa_thermal on end diff --git a/src/mainboard/intel/kblrvp/variants/rvp7/overridetree.cb b/src/mainboard/intel/kblrvp/variants/rvp7/overridetree.cb index c5b7e94..ce4bf4b 100644 --- a/src/mainboard/intel/kblrvp/variants/rvp7/overridetree.cb +++ b/src/mainboard/intel/kblrvp/variants/rvp7/overridetree.cb @@ -153,7 +153,6 @@ # Use default SD card detect GPIO configuration register "sdcard_cd_gpio" = "GPP_G5"
- device cpu_cluster 0 on end device domain 0 on device ref i2c2 off end device ref i2c3 off end diff --git a/src/mainboard/intel/kunimitsu/devicetree.cb b/src/mainboard/intel/kunimitsu/devicetree.cb index 0d9331b..d09a4d1 100644 --- a/src/mainboard/intel/kunimitsu/devicetree.cb +++ b/src/mainboard/intel/kunimitsu/devicetree.cb @@ -161,7 +161,6 @@ # Use default SD card detect GPIO configuration register "sdcard_cd_gpio" = "GPP_A7"
- device cpu_cluster 0 on end device domain 0 on device ref igpu on end device ref sa_thermal on end diff --git a/src/mainboard/intel/saddlebrook/devicetree.cb b/src/mainboard/intel/saddlebrook/devicetree.cb index f2234a6..6756d83 100644 --- a/src/mainboard/intel/saddlebrook/devicetree.cb +++ b/src/mainboard/intel/saddlebrook/devicetree.cb @@ -196,7 +196,6 @@ # Use default SD card detect GPIO configuration #register "sdcard_cd_gpio" = "GPP_A7"
- device cpu_cluster 0 on end device domain 0 on device ref igpu on end device ref south_xhci on end diff --git a/src/mainboard/kontron/bsl6/devicetree.cb b/src/mainboard/kontron/bsl6/devicetree.cb index 08b90ce..f5d05b8 100644 --- a/src/mainboard/kontron/bsl6/devicetree.cb +++ b/src/mainboard/kontron/bsl6/devicetree.cb @@ -63,8 +63,6 @@ # Send an extra VR mailbox command for the PS4 exit issue register "SendVrMbxCmd" = "2"
- device cpu_cluster 0 on end - device domain 0 on device ref igpu on end device ref gmm on end diff --git a/src/mainboard/lenovo/m900_tiny/devicetree.cb b/src/mainboard/lenovo/m900_tiny/devicetree.cb index e9f15d6..e6655b5 100644 --- a/src/mainboard/lenovo/m900_tiny/devicetree.cb +++ b/src/mainboard/lenovo/m900_tiny/devicetree.cb @@ -117,7 +117,6 @@ # Send an extra VR mailbox command for the PS4 exit issue register "SendVrMbxCmd" = "2"
- device cpu_cluster 0 on end device domain 0 on subsystemid 0x17aa 0x30d0 inherit device ref igpu on diff --git a/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb b/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb index aa1f9b2..f4f51b7 100644 --- a/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb +++ b/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb @@ -3,7 +3,6 @@ chip soc/intel/skylake register "eist_enable" = "true"
- device cpu_cluster 0 on end device domain 0 on device ref peg0 on # PCIE16X # These configurations are technically for PCIe root diff --git a/src/mainboard/libretrend/lt1000/devicetree.cb b/src/mainboard/libretrend/lt1000/devicetree.cb index cdddf3d..9d7dedf 100644 --- a/src/mainboard/libretrend/lt1000/devicetree.cb +++ b/src/mainboard/libretrend/lt1000/devicetree.cb @@ -159,7 +159,6 @@ # Send an extra VR mailbox command for the PS4 exit issue register "SendVrMbxCmd" = "2"
- device cpu_cluster 0 on end device domain 0 on device ref igpu on end device ref sa_thermal on end diff --git a/src/mainboard/protectli/vault_kbl/devicetree.cb b/src/mainboard/protectli/vault_kbl/devicetree.cb index 87bc5de..c5a2c56 100644 --- a/src/mainboard/protectli/vault_kbl/devicetree.cb +++ b/src/mainboard/protectli/vault_kbl/devicetree.cb @@ -189,7 +189,6 @@ [PchSerialIoIndexUart2] = PchSerialIoDisabled, }"
- device cpu_cluster 0 on end device domain 0 on device ref igpu on end device ref south_xhci on end diff --git a/src/mainboard/purism/librem_skl/devicetree.cb b/src/mainboard/purism/librem_skl/devicetree.cb index 08a88d6..f844a52 100644 --- a/src/mainboard/purism/librem_skl/devicetree.cb +++ b/src/mainboard/purism/librem_skl/devicetree.cb @@ -149,7 +149,6 @@ # Send an extra VR mailbox command for the PS4 exit issue register "SendVrMbxCmd" = "2"
- device cpu_cluster 0 on end device domain 0 on device ref igpu on end device ref sa_thermal on end diff --git a/src/mainboard/razer/blade_stealth_kbl/devicetree.cb b/src/mainboard/razer/blade_stealth_kbl/devicetree.cb index 71051be..e8da7af 100644 --- a/src/mainboard/razer/blade_stealth_kbl/devicetree.cb +++ b/src/mainboard/razer/blade_stealth_kbl/devicetree.cb @@ -150,7 +150,6 @@ [PchSerialIoIndexUart2] = PchSerialIoDisabled, }"
- device cpu_cluster 0 on end device domain 0 on device ref igpu on register "gfx" = "GMA_STATIC_DISPLAYS(0)" diff --git a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb index 96f7d78..42047b2 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb @@ -46,8 +46,6 @@ LPC_IOE_EC_62_66"
# Actual device tree. - device cpu_cluster 0 on end - device domain 0 on device ref igpu on end device ref sa_thermal on end diff --git a/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb b/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb index 254486c..1a8be1d 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb +++ b/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb @@ -26,7 +26,6 @@ register "PmConfigSlpSusMinAssert" = "SLP_SUS_MIN_ASSERT_4S" register "PmConfigSlpAMinAssert" = "SLP_A_MIN_ASSERT_2S"
- device cpu_cluster 0 on end device domain 0 on device ref sa_thermal on end device ref south_xhci on end diff --git a/src/mainboard/system76/kbl-u/devicetree.cb b/src/mainboard/system76/kbl-u/devicetree.cb index da3327a..d89157c 100644 --- a/src/mainboard/system76/kbl-u/devicetree.cb +++ b/src/mainboard/system76/kbl-u/devicetree.cb @@ -105,8 +105,6 @@ .dc_loadline = 310, }"
- device cpu_cluster 0 on end - device domain 0 on device ref system_agent on end device ref igpu on end diff --git a/src/soc/intel/skylake/chipset.cb b/src/soc/intel/skylake/chipset.cb index 102c55c..6538a14 100644 --- a/src/soc/intel/skylake/chipset.cb +++ b/src/soc/intel/skylake/chipset.cb @@ -1,4 +1,5 @@ chip soc/intel/skylake + device cpu_cluster 0 on end device domain 0 on ops pci_domain_ops device gpio 0 alias pch_gpio on ops block_gpio_ops end
-
Felix Singer (Code Review)