Attention is currently required from: Furquan Shaikh, Paul Menzel, Angel Pons, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56650 )
Change subject: soc/intel/common: Don't suppress SPD Module Type value ......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/smbios.c:
https://review.coreboot.org/c/coreboot/+/56650/comment/a09e0640_e1cf98bd PS3, Line 18: /* Translate to DDR2 module type field that SMBIOS code expects. */
Subrata, I think we need to address the root problem here. Why does the SMBIOS code expect module type in DDR2 format?
Yes i don't know that answer either and IMHO we should let platform choose if they want to go through this conversion or pass the module type directly. I have tested DDR4/5/LP4/5 by passing direct memory type with those few CLs and no DDR2 conversion, I didn't see any issue, so I don't understand why we always need to convert any latest SPD spec into older DDR2 type and feed into SMBIOS function. Can we ignore that conversion. Its possible to add the type conversion how DDR3 had done so far for other memory type as well like DDR4/LP4/5 but does that make sense is my question?