Attention is currently required from: Arthur Heymans, Julius Werner.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84005?usp=email )
Change subject: arch/arm: Fix building with LTO
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/arch/arm/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/84005/comment/2fbe72d1_3c2dc503?usp... :
PS2, Line 100: # Clang LTO does not like the aliasing in here.
Shouldn't this workaround be guarded for clang then? Does it make no difference for GCC?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84005?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3d89c093cee2636e648987a06afb0d325b1d96ff
Gerrit-Change-Number: 84005
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 21 Aug 2024 12:22:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes