Attention is currently required from: Alper Nebi Yasak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80369?usp=email )
Change subject: drivers/qemu/fw_cfg: Support architectures using MMIO
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/emulation/qemu/fw_cfg.c:
https://review.coreboot.org/c/coreboot/+/80369/comment/a37f7edc_03e972de :
PS1, Line 62: #if CONFIG(CPU_QEMU_X86)
Regular C `if ()` is much preferred. I know this isn't straight forward here […]
I've see the cleanup commit, so feel free to ignore, or re-order the patches.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80369?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iacab3f6959cb6af747fde8a5af5cb35ce2bca512
Gerrit-Change-Number: 80369
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Comment-Date: Wed, 07 Feb 2024 16:01:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment