Change in coreboot[master]: drivers/pcie/rtd3/device: Add PCIe RTD3 driver
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Tim Wawrzynczak, Karthik Ramasubramanian, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54966 ) Change subject: drivers/pcie/rtd3/device: Add PCIe RTD3 driver ...................................................................... Patch Set 4: (1 comment) File src/soc/amd/common/block/rtd3/rtd3.c: https://review.coreboot.org/c/coreboot/+/54966/comment/2f165803_77e54154 PS1, Line 210: pci_dev_read_resources
I guess if you have a "naked" nvme device like that (no chip) and you need ACPI entries... […] Hehe. Looks like we have come a full circle here :P. Sorry about the back n forth Raul. What you had initially proposed with a separate chip driver for rtd3 does seem like the better approach. We can ignore the case of bridges for now and just focus on the non-bridge devices downstream by setting PCI ops same as default_pci_ops. Probably make a note that the driver does not handle any downstream graphics devices?
-- To view, visit https://review.coreboot.org/c/coreboot/+/54966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2adfc925183ff7a19ab97e89212bc87c40d552d0 Gerrit-Change-Number: 54966 Gerrit-PatchSet: 4 Gerrit-Owner: Raul Rangel <rrangel@chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Duncan Laurie <dlaurie@gmail.com> Gerrit-CC: Furquan Shaikh <furquan@google.com> Gerrit-CC: Mario Limonciello <mario.limonciello@amd.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Attention: Raul Rangel <rrangel@chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-Comment-Date: Thu, 03 Jun 2021 16:19:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel@chromium.org> Comment-In-Reply-To: Furquan Shaikh <furquan@google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-MessageType: comment
participants (1)
-
Furquan Shaikh (Code Review)