Change in coreboot[master]: mb/teleplatforms/D4E4S16P8: Add CRB using intel/denverton_ns

Attention is currently required from: Dmitry Ponamorev, Jeff Daly, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Angel Pons, Michal Motyl, Patrick Rudolph, King Sumo. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57194 ) Change subject: mb/teleplatforms/D4E4S16P8: Add CRB using intel/denverton_ns ...................................................................... Patch Set 26: (1 comment) File src/mainboard/teleplatforms/D4E4S16P8/devicetree.cb: https://review.coreboot.org/c/coreboot/+/57194/comment/eca86bf6_7e6dcc39 PS26, Line 49: 06
This device number is suspicious, isn't this downstream of the root port? Right, they are wrong, it's listing the bus number as device number.
Should be fine to just remove these, I'll test it. -- To view, visit https://review.coreboot.org/c/coreboot/+/57194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If654fc7a391643b50f2e52755fd7c11a37bfd188 Gerrit-Change-Number: 57194 Gerrit-PatchSet: 26 Gerrit-Owner: Dmitry Ponamorev <dponamorev@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Dmitry Ponamorev <dponamorev@gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd@silicom-usa.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski@intel.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl@intel.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli@intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: King Sumo <kingsumos@gmail.com> Gerrit-Attention: Dmitry Ponamorev <dponamorev@gmail.com> Gerrit-Attention: Jeff Daly <jeffd@silicom-usa.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski@intel.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli@intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio@intel.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Michal Motyl <michalx.motyl@intel.com> Gerrit-Attention: Patrick Rudolph <siro@das-labor.org> Gerrit-Attention: King Sumo <kingsumos@gmail.com> Gerrit-Comment-Date: Tue, 05 Apr 2022 17:33:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
participants (1)
-
Kyösti Mälkki (Code Review)