Attention is currently required from: Nico Huber.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49408 )
Change subject: soc/intel/common: Add new IRQ module
......................................................................
Patch Set 7:
(2 comments)
File src/soc/intel/common/block/irq/irq.c:
https://review.coreboot.org/c/coreboot/+/49408/comment/d46bf0c6_48d7a638
PS7, Line 204: if (!is_valid_pin(constraints[i].pci_pin)) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/49408/comment/cb90c171_428ccde1
PS7, Line 231: printk(BIOS_ERR, "ERROR: %s: No free pins left for UNIQUE IRQ\n", __func__);
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49408
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c22a08ce589fa80d0bb1e637422304a3af2045c
Gerrit-Change-Number: 49408
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 19 Feb 2021 01:10:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment